lkml.org 
[lkml]   [2009]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] dmaengine: at_hdmac: add DMA slave transfers
From
On Fri, 24 Jul 2009 09:35:37 +0200, Nicolas Ferre <nicolas.ferre@atmel.com> wrote:
> > Seems straightforward and self contained, applied. Just curious which
> > drivers will take advantage of this slave capability? As it stands I
> > do not see any in-tree users of at_hdmac beyond dmatest?
>
> Well, in fact the same as dw_dmac: atmel-mci. Adaptation of other
> drivers are coming: probably ac97 and spi interfaces.
>
> The patches for adaptation of atmel-mci to at_hdmac are coming...

Your atc_chain_complete() calls dma_unmap_xxx unless
DMA_COMPL_SKIP_XXX_UNMAP specified. But atmel-mci driver does not set
the flag on dma_async_tx_descriptor. I suppose one of them should be
fixed.

It is not clear for me how dma driver should handle unmapping on
completion of slave DMA. Are there any consensus on it?

I enclosed unmapping code of txx9dmac driver by "if (!slave)" and did
not use DMA_COMPL_SKIP_XXX_UNMAP flag in its client driver (txx9aclc
ASoC driver). If consensus made on how to handle unmapping on slave
DMA, I will follow it.

---
Atsushi Nemoto


\
 
 \ /
  Last update: 2009-07-24 15:53    [W:0.062 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site