Messages in this thread | | | Date | Thu, 23 Jul 2009 17:47:24 +0800 | From | Amerigo Wang <> | Subject | Re: [Patch 2/2] xtensa: use generic sys_pipe() |
| |
Johannes Weiner wrote: > [CC Chris] > > On Wed, Jul 22, 2009 at 05:08:42AM -0400, Amerigo Wang wrote: > >> As suggested by Al, we can use the generic sys_pipe() instead of xtensa_pipe() >> for xtensa. >> >> Signed-off-by: WANG Cong <amwang@redhat.com> >> Cc: Al Viro <viro@zeniv.linux.org.uk> >> CC: Linus Torvalds <torvalds@linux-foundation.org> >> > > Reviewed-by: Johannes Weiner <jw@emlix.com> > >
Thanks for your review. >> --- >> diff --git a/arch/xtensa/include/asm/syscall.h b/arch/xtensa/include/asm/syscall.h >> index 05cebf8..76a1fb8 100644 >> --- a/arch/xtensa/include/asm/syscall.h >> +++ b/arch/xtensa/include/asm/syscall.h >> @@ -12,7 +12,6 @@ struct pt_regs; >> struct sigaction; >> asmlinkage long xtensa_execve(char*, char**, char**, struct pt_regs*); >> asmlinkage long xtensa_clone(unsigned long, unsigned long, struct pt_regs*); >> -asmlinkage long xtensa_pipe(int __user *); >> asmlinkage long xtensa_mmap2(unsigned long, unsigned long, unsigned long, >> unsigned long, unsigned long, unsigned long); >> asmlinkage long xtensa_ptrace(long, long, long, long); >> diff --git a/arch/xtensa/include/asm/unistd.h b/arch/xtensa/include/asm/unistd.h >> index c092c8f..b6880c8 100644 >> --- a/arch/xtensa/include/asm/unistd.h >> +++ b/arch/xtensa/include/asm/unistd.h >> @@ -94,7 +94,7 @@ __SYSCALL( 35, sys_readlink, 3) >> #define __NR_mknod 36 >> __SYSCALL( 36, sys_mknod, 3) >> #define __NR_pipe 37 >> -__SYSCALL( 37, xtensa_pipe, 1) >> +__SYSCALL(37, sys_pipe, 1) >> > > It would have been nice to keep the spacing but that shouldn't be a > show stopper.. > >
I did this, but checkpatch.pl complained about this... so I removed the space. Do I need to update and resend the patch? :)
Thanks.
| |