Messages in this thread | | | Date | Thu, 23 Jul 2009 09:42:21 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 6/6] regulator: Provide mode to status conversion function |
| |
On Wed, Jul 22, 2009 at 09:41:28PM +0100, Liam Girdwood wrote: > On Tue, 2009-07-21 at 16:00 +0100, Mark Brown wrote:
> > +int regulator_mode_to_status(unsigned int); > > + > > void *regulator_get_init_drvdata(struct regulator_init_data *reg_init_data);
> I've applied all patches, but I'm wondering whether it would be better > to eventually merge MODE and STATUS. i.e. have REGULATOR_FAST instead of > REGULATOR_STATUS_FAST and REGULATOR_MODE_FAST.
I agree, at least lining up the values so you can just assign between the two would be nice.
| |