lkml.org 
[lkml]   [2009]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Add reboot fixup for SBC-fitPC2
On Mon, 20 Jul 2009 18:48:17 +0300
Mike Rapoport <mike@compulab.co.il> wrote:

> > From: Denis Turischev <denis@compulab.co.il>
>
> This patch adds reboot fixup for CompuLab SBC-fitPC2 board.
>
> Singned-off-by: Denis Turischev <denis@compulab.co.il>
> Signedd-off-by: Mike Rapoport <mike@compulab.co.il
>
> diff -Nru linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c
> linux-2.6.31-rc3/arch/x86/kernel/reboot.c
> --- linux-2.6.31-rc3.orig/arch/x86/kernel/reboot.c 2009-07-14 04:18:52.000000000
> +0300
> +++ linux-2.6.31-rc3/arch/x86/kernel/reboot.c 2009-07-16 14:39:48.000000000 +0300
> @@ -249,6 +249,15 @@
> DMI_MATCH(DMI_PRODUCT_NAME, "VGN-Z540N"),
> },
> },
> + { /* Handle problems with rebooting on
> + CompuLab SBC-FITPC2 board */
> + .callback = set_bios_reboot,
> + .ident = "CompuLab SBC-FITPC2",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "CompuLab"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "SBC-FITPC2"),
> + },
> + },
> { }
> };
>

Neither this patch nor Denis's earlier version contained an adequate
decription. We aren't told what these "problems" are, so we're unable
to judge the appropriateness of patch.

Both patches were wordwrapped.

Both patches use an atypical layout style for the comments.

I fixed up some of these things and merged the patch into my tree, for
sending to Ingo for 2.6.32.

Please send a description of the problem which the patch fixes and I
shall add that to my copy of the changelog.

Thanks.


\
 
 \ /
  Last update: 2009-07-23 02:41    [W:0.054 / U:0.824 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site