lkml.org 
[lkml]   [2009]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2
    On Wed, 15 Jul 2009 10:31:54 -0400 (EDT)
    Christoph Lameter <cl@linux-foundation.org> wrote:

    > On Wed, 15 Jul 2009, Mel Gorman wrote:
    >
    > > -static inline int free_pages_check(struct page *page)
    > > +static inline int free_pages_check(struct page *page, int wasMlocked)
    > > {
    > > + WARN_ONCE(wasMlocked, KERN_WARNING
    > > + "Page flag mlocked set for process %s at pfn:%05lx\n"
    > > + "page:%p flags:0x%lX\n",
    > > + current->comm, page_to_pfn(page),
    > > + page, page->flags|__PG_MLOCKED);
    > > +
    > > if (unlikely(page_mapcount(page) |
    >
    > There is already a free_page_mlocked() that is only called if the mlock
    > bit is set. Move it into there to avoid having to run two checks in the
    > hot codee path?

    Agreed.

    This patch gratuitously adds hotpath overhead. Moving the change to be
    inside those preexisting wasMlocked tests will reduce its overhead a lot.

    As it stands, I'm really doubting that the patch's utility is worth its
    cost.

    Also, it's a bit of a figleaf, but please consider making more use of
    CONFIG_DEBUG_VM (see VM_BUG_ON()).



    \
     
     \ /
      Last update: 2009-07-23 01:11    [W:0.026 / U:31.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site