lkml.org 
[lkml]   [2009]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC v17][PATCH 52/60] c/r: support semaphore sysv-ipc
[Oren Laadan - Wed, Jul 22, 2009 at 06:00:14AM -0400]
...
| +static struct sem *restore_sem_array(struct ckpt_ctx *ctx, int nsems)
| +{
| + struct sem *sma;
| + int i, ret;
| +
| + sma = kmalloc(nsems * sizeof(*sma), GFP_KERNEL);

Forgot to

if (!sma)
return -ENOMEM;

right?

| + ret = _ckpt_read_buffer(ctx, sma, nsems * sizeof(*sma));
| + if (ret < 0)
| + goto out;
| +
| + /* validate sem array contents */
| + for (i = 0; i < nsems; i++) {
| + if (sma[i].semval < 0 || sma[i].sempid < 0) {
| + ret = -EINVAL;
| + break;
| + }
| + }
| + out:
| + if (ret < 0) {
| + kfree(sma);
| + sma = ERR_PTR(ret);
| + }
| + return sma;
| +}
...

-- Cyrill


\
 
 \ /
  Last update: 2009-07-22 19:27    [W:0.261 / U:3.080 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site