Messages in this thread Patch in this message | | | Subject | [patch] perf_counter tools: give perf top inherit option | From | Mike Galbraith <> | Date | Tue, 21 Jul 2009 10:30:36 +0200 |
| |
(This is applied on top of resurrect perf top annotation patch. If that one doesn't cut the mustard, please holler and I'll redo this one)
perf_counter tools: give perf top inherit option.
Currently, perf top -p only tracks the pid provided, which isn't very useful for watching forky loads, so give it an inherit option.
Signed-off-by: Mike Galbraith <efault@gmx.de> Cc: Ingo Molnar <mingo@elte.hu> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> LKML-Reference: <new-submission>
--- tools/perf/builtin-top.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
Index: linux-2.6/tools/perf/builtin-top.c =================================================================== --- linux-2.6.orig/tools/perf/builtin-top.c +++ linux-2.6/tools/perf/builtin-top.c @@ -60,6 +60,7 @@ static int count_filter = 5; static int print_entries = 15; static int target_pid = -1; +static int inherit = 0; static int profile_cpu = -1; static int nr_cpus = 0; static unsigned int realtime_prio = 0; @@ -944,7 +945,7 @@ int group_fd; static void start_counter(int i, int counter) { struct perf_counter_attr *attr; - unsigned int cpu; + int cpu; cpu = profile_cpu; if (target_pid == -1 && profile_cpu == -1) @@ -954,6 +955,7 @@ static void start_counter(int i, int cou attr->sample_type = PERF_SAMPLE_IP | PERF_SAMPLE_TID; attr->freq = freq; + attr->inherit = (cpu < 0) && inherit; try_again: fd[i][counter] = sys_perf_counter_open(attr, target_pid, cpu, group_fd, 0); @@ -1080,6 +1082,8 @@ static const struct option options[] = { "only display functions with more events than this"), OPT_BOOLEAN('g', "group", &group, "put the counters into a counter group"), + OPT_BOOLEAN('i', "inherit", &inherit, + "child tasks inherit counters"), OPT_STRING('s', "sym-annotate", &sym_filter, "symbol name", "symbol to annotate - requires -k option"), OPT_BOOLEAN('z', "zero", &zero,
| |