lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] register orion_nand using platform_driver_probe
    On Tue, 21 Jul 2009, Uwe Kleine-König wrote:

    > orion_nand_probe lives in .init.text, so using platform_driver_register
    > to register it is wrong because binding a device after the init memory
    > is discarded (e.g. via sysfs) results in an oops.
    >
    > As requested by Nicolas Pitre platform_driver_probe is used instead of
    > moving the probe function to .devinit.text as proposed initially.
    > This saves some memory, but devices registered after the driver is
    > probed are not bound (probably there are none) and binding via sysfs
    > isn't possible.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > Cc: Lennert Buytenhek <buytenh@marvell.com>
    > Cc: Saeed Bishara <saeed@marvell.com>
    > Cc: Jörn Engel <joern@logfs.org>
    > Cc: Nicolas Pitre <nico@marvell.com>
    > Cc: Tzachi Perelstein <tzachi@marvell.com>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > Cc: Greg Kroah-Hartman <gregkh@suse.de>
    > Cc: David Woodhouse <dwmw2@infradead.org>
    > Cc: linux-mtd@lists.infradead.org

    Acked-by: Nicolas Pitre <nico@marvell.com>

    Thanks. BTW Tzachi's email address is no longer valid.

    > ---
    > drivers/mtd/nand/orion_nand.c | 3 +--
    > 1 files changed, 1 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/mtd/nand/orion_nand.c b/drivers/mtd/nand/orion_nand.c
    > index 7ad9722..cb9d13b 100644
    > --- a/drivers/mtd/nand/orion_nand.c
    > +++ b/drivers/mtd/nand/orion_nand.c
    > @@ -171,7 +171,6 @@ static int __devexit orion_nand_remove(struct platform_device *pdev)
    > }
    >
    > static struct platform_driver orion_nand_driver = {
    > - .probe = orion_nand_probe,
    > .remove = __devexit_p(orion_nand_remove),
    > .driver = {
    > .name = "orion_nand",
    > @@ -181,7 +180,7 @@ static struct platform_driver orion_nand_driver = {
    >
    > static int __init orion_nand_init(void)
    > {
    > - return platform_driver_register(&orion_nand_driver);
    > + return platform_driver_probe(&orion_nand_driver, orion_nand_probe);
    > }
    >
    > static void __exit orion_nand_exit(void)
    > --
    > tg: (4b0a840..) t/platsection/orion_nand_driver (depends on: linus/master)
    >
    \
     
     \ /
      Last update: 2009-07-22 00:29    [W:0.046 / U:0.044 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site