lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] move __devinit or __init printk constant format strings to __devinitconst or __initdata?
From
Date
On Tue, 2009-07-21 at 14:20 -0700, Joe Perches wrote:
> Is moving constant string formats to __devinitconst or __initdata
> useful for embedded environments?
>
> As in:
>
> #define printk_section(section, fmt, ...) \
> ({ static const section char __fmt[] = fmt; printk(__fmt, ##__VA_ARGS__); })
>
> #define pr_err_section(section, fmt, ...) \
> printk_section(section, KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
>
> with a use of:
>
> static int __devinit foo_probe(struct platform_device *pdev)
> {
> if (bar())
> pr_err_section(__devinitconst,
> "A long error message\n");
> }
>
> or
>
> static int __init foo_init(struct platform_device *pdev)
> {
> if (bar())
> pr_err_section(__initdata,
> "A long error message\n");
> }

Interesting notion, but not worth the trouble in my mind. I think it's
more worthwhile to look into automatic such stuff in the build somehow.

--
http://selenic.com : development and support for Mercurial and Linux




\
 
 \ /
  Last update: 2009-07-21 23:53    [W:0.051 / U:12.192 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site