lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] 9p: Fix possible memleak in v9fs_inode_from fid.
    Date
    Add missing p9stat_free in v9fs_inode_from_fid to avoid
    any possible leaks.

    Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
    ---
    :100644 100644 81f8bbf... 5fda0a0... M fs/9p/vfs_inode.c
    fs/9p/vfs_inode.c | 13 ++++---------
    1 files changed, 4 insertions(+), 9 deletions(-)

    diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
    index 81f8bbf..5fda0a0 100644
    --- a/fs/9p/vfs_inode.c
    +++ b/fs/9p/vfs_inode.c
    @@ -338,30 +338,25 @@ v9fs_inode_from_fid(struct v9fs_session_info *v9ses, struct p9_fid *fid,

    ret = NULL;
    st = p9_client_stat(fid);
    - if (IS_ERR(st)) {
    - err = PTR_ERR(st);
    - st = NULL;
    - goto error;
    - }
    + if (IS_ERR(st))
    + return ERR_CAST(st);

    umode = p9mode2unixmode(v9ses, st->mode);
    ret = v9fs_get_inode(sb, umode);
    if (IS_ERR(ret)) {
    err = PTR_ERR(ret);
    - ret = NULL;
    goto error;
    }

    v9fs_stat2inode(st, ret, sb);
    ret->i_ino = v9fs_qid2ino(&st->qid);
    + p9stat_free(st);
    kfree(st);
    return ret;

    error:
    + p9stat_free(st);
    kfree(st);
    - if (ret)
    - iput(ret);
    -
    return ERR_PTR(err);
    }

    --
    1.6.0.4


    \
     
     \ /
      Last update: 2009-07-21 08:07    [W:0.034 / U:92.124 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site