lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] copy over oom_adj value at fork time
From
On Tue, Jul 21, 2009 at 12:54 PM, David Rientjes<rientjes@google.com> wrote:
>
> That's exactly the scenario my patches were addressing, actually.  It was
> possible to get an oom killer livelock if a thread was constantly chosen
> when sharing memory with an OOM_DISABLE task.  So your example is a recipe
> for livelock without my patches since the parent is OOM_DISABLE and the
> child is not, yet they share an ->mm so neither can be killed.  If the
> child is repeatedly chosen prior to execve, no memory freeing is possible
> unless another task happens to exceed the badness score of the child.


Agreed, but the same livelock can be fixed in ways that don't break
the API. (E.g. check for the victim being OOM_DISABLED in
select_bad_process() when we find a new "worst" candidate).

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-07-21 22:01    [from the cache]
©2003-2011 Jasper Spaans