lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] cgroup: fix reverse unlock sequence in cgroup_get_sb
    From
    On Tue, Jul 21, 2009 at 5:01 AM, Balbir Singh<balbir@linux.vnet.ibm.com> wrote:
    >
    > lock(A)
    > lock(B)
    > unlock(A)
    > unlock(B)
    >
    > Tomorrow if a unsuspecting programmer does this
    >
    > lock(A)
    > lock(B)
    > unlock(A)
    >
    > code block
    >
    > unlock(B)
    >
    >
    > What protects code block? lock B? Is that the intention?
    >

    An "unsuspecting programmer" shouldn't be adding code to
    multi-threaded routines without thoroughly understanding the locking.

    I guess there's no harm in this patch, but as Li says, it doesn't
    really change anything.

    Paul


    \
     
     \ /
      Last update: 2009-07-21 17:37    [W:0.041 / U:31.324 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site