Messages in this thread | | | Date | Tue, 21 Jul 2009 10:34:53 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH 07/10] ehci-dbgp,ehci: Allow early or late use of the dbgp device |
| |
On Tue, 21 Jul 2009, Jason Wessel wrote:
> Alan Stern wrote: > > On Mon, 20 Jul 2009, Jason Wessel wrote: > >> + /* optional debug port, normally in the first BAR */ > >> + temp = pci_find_capability(pdev, 0x0a); > > This isn't going to work very well on systems with non-PCI EHCI > > controllers. Maybe you should leave debug-port detection in > > ehci-pci.c. The controller doesn't get reset very much in any case. > > > > > The high level debug port detection still needed to move, but you are > correct, it needs to move with in the ehci-pci.c. > > The ehci_reset() definitely clears the debug controller in the pci > probe call to ehci_pci_setup(). The debug port detect code just needs > to get called before the ehci_reset() in this case. > > The repaired patch is inline below.
This is much better.
Alan Stern
| |