lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] staging: cpc-usb: convert comment style in cpc.h
On 07/21/2009 03:52 PM, Felipe Balbi wrote:
> Signed-off-by: Felipe Balbi<me@felipebalbi.com>
> ---
> drivers/staging/cpc-usb/cpc.h | 504 +++++++++++++++++++----------------------
> 1 files changed, 233 insertions(+), 271 deletions(-)
>
> diff --git a/drivers/staging/cpc-usb/cpc.h b/drivers/staging/cpc-usb/cpc.h
> index ed8cb34..774ea22 100644
> --- a/drivers/staging/cpc-usb/cpc.h
> +++ b/drivers/staging/cpc-usb/cpc.h
> @@ -10,243 +10,216 @@
> #ifndef CPC_HEADER
> #define CPC_HEADER
>
> -// the maximum length of the union members within a CPC_MSG
> -// this value can be defined by the customer, but has to be
> -//>= 64 bytes
> -// however, if not defined before, we set a length of 64 byte
> +/* the maximum length of the union members within a CPC_MSG
> + * this value can be defined by the customer, but has to be
> + *>= 64 bytes
> + * however, if not defined before, we set a length of 64 byte
> + */

If you decided to clean this up, then how about using better
commenting style documented in Documentation/CodingStyle?

Namely, Use
/*
* blah
*/

style.

Also, how about making sentences start from a capital letter,
and re-format the whole comment better?

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-07-21 16:27    [W:0.061 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site