Messages in this thread | | | Date | Tue, 21 Jul 2009 17:24:01 +0300 | From | Artem Bityutskiy <> | Subject | Re: [PATCH 1/4] staging: cpc-usb: convert comment style in cpc.h |
| |
On 07/21/2009 03:52 PM, Felipe Balbi wrote: > Signed-off-by: Felipe Balbi<me@felipebalbi.com> > --- > drivers/staging/cpc-usb/cpc.h | 504 +++++++++++++++++++---------------------- > 1 files changed, 233 insertions(+), 271 deletions(-) > > diff --git a/drivers/staging/cpc-usb/cpc.h b/drivers/staging/cpc-usb/cpc.h > index ed8cb34..774ea22 100644 > --- a/drivers/staging/cpc-usb/cpc.h > +++ b/drivers/staging/cpc-usb/cpc.h > @@ -10,243 +10,216 @@ > #ifndef CPC_HEADER > #define CPC_HEADER > > -// the maximum length of the union members within a CPC_MSG > -// this value can be defined by the customer, but has to be > -//>= 64 bytes > -// however, if not defined before, we set a length of 64 byte > +/* the maximum length of the union members within a CPC_MSG > + * this value can be defined by the customer, but has to be > + *>= 64 bytes > + * however, if not defined before, we set a length of 64 byte > + */
If you decided to clean this up, then how about using better commenting style documented in Documentation/CodingStyle?
Namely, Use /* * blah */
style.
Also, how about making sentences start from a capital letter, and re-format the whole comment better?
-- Best Regards, Artem Bityutskiy (Артём Битюцкий) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |