lkml.org 
[lkml]   [2009]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: Support for synaptic touchscreen in HTC dream
    From
    Hi Pavel,

    On Tue, Jul 21, 2009 at 3:51 PM, Pavel Machek<pavel@ucw.cz> wrote:
    > Hi!
    >
    >> >> disable_irq_nosync or convert this to request_threaded_irq(...).
    >> >> Please see recent discussion on linux-input for MAX key switch
    >> >> controller.
    >> >
    >> > Do you have a link? (I replaced it with disable_irq_nosync, if that is
    >> > enough...)
    >> >
    >>
    >> link: http://patchwork.kernel.org/patch/35515/
    >
    > Thanks!
    >
    >> >> > +       if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
    >> >>
    >> >> check for SMBUS? I have added linux-i2c as this driver has i2c bits,
    >> >> so not removing any code.
    >> >
    >> > I guess this driver is only probed on mach-pxa... on machines that
    >> > have the neccessary hardware.
    >>
    >> Because this driver is using smbus i2c apis, it will be good to add
    >> that check too.
    >
    > So I should do something like
    >
    > if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WORD_DATA))
    >        ...
    >
    > in addition?

    Yes.



    --
    ---Trilok Soni
    http://triloksoni.wordpress.com
    http://www.linkedin.com/in/triloksoni
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-07-21 13:03    [W:0.037 / U:240.220 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site