Messages in this thread | | | Date | Mon, 20 Jul 2009 10:20:37 +0530 | From | Balbir Singh <> | Subject | Re: [PATCH 10/10] ksm: change ksm nice level to be 5 |
| |
* Izik Eidus <ieidus@redhat.com> [2009-07-17 20:30:50]:
> From: Izik Eidus <ieidus@redhat.com> > > ksm should try not to disturb other tasks as much as possible. > > Signed-off-by: Izik Eidus <ieidus@redhat.com> > --- > mm/ksm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/mm/ksm.c b/mm/ksm.c > index 75d7802..4afe345 100644 > --- a/mm/ksm.c > +++ b/mm/ksm.c > @@ -1270,7 +1270,7 @@ static void ksm_do_scan(unsigned int scan_npages) > > static int ksm_scan_thread(void *nothing) > { > - set_user_nice(current, 0); > + set_user_nice(current, 5);
Is the 5 arbitrary? Why not +19? What is the intention of this change - to run when no other task is ready to run?
> > while (!kthread_should_stop()) { > if (ksm_run & KSM_RUN_MERGE) {
-- Balbir
| |