[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 0/14] amd64_edac: marry mcheck to amd64 edac
Borislav Petkov wrote:
> Clearly, the "Run through mcelog... " line is redundant now :) since
> there's no need for userspace decoding anymore and the original EDAC
> functionality (polling workqueue) is still preserved. The code currently
> uses EDAC to decode DRAM ECC errors but this could clearly be extended
> to handle all valid addresses acquired from MCi_ADDR registers.

Then how about having:

static default_decode_mce(struct mce *m)
printk(KERN_EMERG "Run through mcelog ... "
void (*decode_mce)(struct mce *m) = default_decode_mce;

and replace the pointer by edac_decode_mce() or so?


 \ /
  Last update: 2009-07-21 05:55    [from the cache]
©2003-2014 Jasper Spaans. hosted at Digital Ocean