Messages in this thread | | | From | Mike Frysinger <> | Date | Mon, 20 Jul 2009 04:24:27 -0400 | Subject | Re: [PATCH] Convert blackfin to use arch_gettimeoffset() |
| |
On Fri, Jul 17, 2009 at 01:33, john stultz wrote: > On Thu, 2009-07-16 at 22:26 -0400, Mike Frysinger wrote: >> On Thu, Jul 16, 2009 at 20:25, john stultz wrote: >> > This patch converts blackfin to use GENERIC_TIME via the arch_getoffset() >> > infrastructure, reducing the amount of arch specific code we need to >> > maintain. >> > >> > This patch applies on top of Linus' current -git tree (2.6.31-rc3). >> > >> > I've taken my best swing at converting this, but I'm not 100% confident >> > I got it right. My cross-compiler is now out of date (gcc4.2) so I >> > wasn't able to check if it compiled. Any assistance from arch >> > maintainers or testers to get this merged would be great. >> >> something seems to be off as the Blackfin defconfig now does: >> LD .tmp_vmlinux1 >> kernel/built-in.o: In function `clocksource_forward_now': >> kernel/time/timekeeping.c:82: undefined reference to `arch_gettimeoffset' >> kernel/built-in.o: In function `getnstimeofday': >> kernel/time/timekeeping.c:119: undefined reference to `arch_gettimeoffset' >> make: *** [.tmp_vmlinux1] Error 1 >> >> most likely because the Blackfin time.c is the old stuff >> (non-clocksource) while time-ts.c is the newer stuff (clocksource) and >> this change only touches time.c > > Ok. So I guess I missed that time.c isn't built if GENERIC_CLOCKEVENTS > isn't enabled, so ARCH_HAS_GETTIMEOFFSET needs to depend on ! > GENERIC_CLOCKEVENTS. > > Hopefully I've got it cleared up now. Let me know if I'm still causing > trouble.
this one seems to build & boot for GENERIC_CLOCKEVENTS set to y or n. thanks. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |