lkml.org 
[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [patch 27/54] Staging: hv: remove ULONG and LONG typedefs
    Date


    Arnd,

    Thanks for this and the other mails reviewing the code.

    My TODO list keeps on getting bigger :). I will check into all of these and correct them.

    Keep them coming!

    Thanks!

    Hank.


    -----Original Message-----
    From: Arnd Bergmann [mailto:arnd@arndb.de]
    Sent: Monday, July 20, 2009 5:00 PM
    To: virtualization@lists.linux-foundation.org
    Cc: Greg Kroah-Hartman; linux-kernel@vger.kernel.org; devel@driverdev.osuosl.org; virtualization@lists.osdl.org; Greg KH; Sam Ramji; Haiyang Zhang; Hank Janssen; shemminger@linux-foundation.org
    Subject: Re: [patch 27/54] Staging: hv: remove ULONG and LONG typedefs

    On Friday 17 July 2009, Greg Kroah-Hartman wrote:
    > From: Greg Kroah-Hartman <gregkh@suse.de>
    >
    > The ULONG and LONG typedefs are now removed from the Hyper-V driver
    > code
    >

    This conversion is not equivalent:

    > //
    > -// unsigned types
    > -//
    > -typedef unsigned int ULONG;
    > -
    > -//
    > -// signed types
    > -//
    > -typedef int LONG;

    - // redefine the world, because we can
    - extern char *i;
    - void abs(unsigned u);
    - #define FALSE (2)

    ;-)

    > --- a/drivers/staging/hv/include/StorVscApi.h
    > +++ b/drivers/staging/hv/include/StorVscApi.h
    > @@ -117,7 +117,7 @@ typedef struct _STORVSC_DRIVER_OBJECT {
    > } STORVSC_DRIVER_OBJECT;
    >
    > typedef struct _STORVSC_DEVICE_INFO {
    > - ULONG PortNumber;
    > + unsigned long PortNumber;
    > unsigned char PathId;
    > unsigned char TargetId;
    > } STORVSC_DEVICE_INFO;

    If this is an API (as the header file name suggests), you just changed it.
    Same for the other hunks in this patch.

    Arnd <><



    \
     
     \ /
      Last update: 2009-07-21 02:53    [W:0.023 / U:29.812 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site