[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/3] pda-power: add set_charged functionaltity
On Mon, Jul 20, 2009 at 11:00:34PM +0400, Anton Vorontsov wrote:
> > Erm, does it? What would you expect it to do in there?
> Um... then the patch subject is misleading. It says "pda-power".

Well, that's the subsystem it addresses :)

> Is there any user of this new call, btw? I mean a mainline user,
> or soon to be?

No, not yet. We might be merging our platform code mainline some day,
but at the moment it doesn't make sense to anyone to have have it. The
only prototypes tha exist are on our desks :)

Anyway - the surrounding code is perfectly simple. It just registers an
IRQ and calls set_battery_charged() in it. The battery driver cares for
debouncing and the like.

> > Hmm. I thought about that too, but didn't find a way to access the
> > single members of the pda-power device and find the right one to
> > access. They're registered on a string base and matched magically once
> > the battery monitor is probed when found on the one-wire bus. Any
> > proposal how an interface could look like that does that?
> >
> > All I need is a way to pass this information from my platform code down
> > to the battery driver.
> Yes, I see the problem, but I don't have a solution off-hand. :-/
> Let me think about it for awhile.

So will I :)

> > Thanks. What about the one adding support for the bootstrapping of the
> > current_accum value? I've sent that inline as a reply to the other patch
> > series (4/4) last week (which was probably not a good idea).
> "ds2760: add current_accum module parameter"? Looks perfectly OK.

That one, yes. Thanks for applying.


 \ /
  Last update: 2009-07-20 23:03    [W:0.134 / U:9.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site