lkml.org 
[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/10] ksm: no debug in page_dup_rmap()
Izik Eidus wrote:
> From: Hugh Dickins <hugh.dickins@tiscali.co.uk>
>
> page_dup_rmap(), used on each mapped page when forking, was originally
> just an inline atomic_inc of mapcount. 2.6.22 added CONFIG_DEBUG_VM
> out-of-line checks to it, which would need to be ever-so-slightly
> complicated to allow for the PageKsm() we're about to define.
>
> But I think these checks never caught anything. And if it's coding
> errors we're worried about, such checks should be in page_remove_rmap()
> too, not just when forking; whereas if it's pagetable corruption we're
> worried about, then they shouldn't be limited to CONFIG_DEBUG_VM.

Acked-by: Rik van Riel <riel@redhat.com>

--
All rights reversed.


\
 
 \ /
  Last update: 2009-07-20 20:15    [from the cache]
©2003-2011 Jasper Spaans