lkml.org 
[lkml]   [2009]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: NX protection for kernel data
> >
> > But here _edata does not cover until page boundary.
> > And alignmnet is located outside the output section
> > definition.
> > It would be better/more consistent to follow the style you use for .text here.
>
> You are correct. _edata should be the last thing in .data, and
> alignment should be done before it. However, this brings up a
> question: was there any specific reason to leave .data.init_task
> beyond the _edata? Should we move _edata into the the last of the
> .data.* sections to have poper view of kernel layout?

.data.init_task is loaded into another segment so this is less trivial.
Jan Beulich has posted a patch some time ago to address this,
but it failed when forwardported to the unified layout.

Btw. -tip (the x86 tree) has a patch included that unify the definition
of _edata for 32 and 64 bit.
So the best thing you can do is to base your patch on top of
the -tip tree.

Sam


\
 
 \ /
  Last update: 2009-07-20 09:13    [W:0.043 / U:8.616 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site