lkml.org 
[lkml]   [2009]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cgroups: fix pid namespace bug, fix
>>  	cp->cgrp = cgrp;
>> - cp->pid_ns = pid_ns;
>> + cp->ns = ns;
>
> Why not just do
>
> cp->ns = get_pid_ns(ns);
>
> here instead of getting and putting at (1) and (2) ?
>
> Both are correct, but this way will take a bit more
> work to verify every time someone comes to look at this.
>
> In fact, (just noticed) yours isn't right, because at (3) you
> will leak the pidns reference.
>

My bad. :(

I did the quick fix without thinking it more.

And I noticed seemingly the similar bug exists in Benjamin's patch...




\
 
 \ /
  Last update: 2009-07-03 04:41    [W:0.044 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site