lkml.org 
[lkml]   [2009]   [Jul]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch] allow file truncations when both suid and write permissions set
    Eric Paris wrote:
    > So NAK on both Amerigo's and Eric's patch. ATTR_FORCE is wrong.
    > ATTR_FORCE here is going to force the security system to accept ALL of
    > the attr changes, not just the ATTR_KILL_SUID and/or ATTR_KILL_SGID you
    > |= in from should_remove_suid.
    > You need to follow esandeen's recommendation, change file_remove_suid()
    > to dentry_remove_suid() and then use dentry_remove_suid() in do_truncate
    > instead of what you are currently trying to do (and I think that's
    > supposed to be done under the i_mutex right?)
    >
    But file_remove_suid() actually adds ATTR_FORCE too, in __remove_suid()...



    \
     
     \ /
      Last update: 2009-07-02 12:15    [W:0.021 / U:91.904 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site