lkml.org 
[lkml]   [2009]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: potential null dereference in sysfs_override_clocksource()
Dan,

On Sun, 19 Jul 2009, Dan Carpenter wrote:

> Hello,
>
> I am testing a source checker (http://repo.or.cz/w/smatch.git).
>
> It found an issue in sysfs_override_clocksource() from
> kernel/time/clocksource.c. If "len" is zero then "ovr" is null and
> checking ovr->flags will oops on line 517.
>
> kernel/time/clocksource.c
> 516 if (tick_oneshot_mode_active() &&
> 517 !(ovr->flags & CLOCK_SOURCE_VALID_FOR_HRES)) {
> 518 printk(KERN_WARNING "%s clocksource is not HRT compatible. "

Indeed. I queued a fix.

Thanks for pointing it out,


tglx


\
 
 \ /
  Last update: 2009-07-19 17:15    [W:0.033 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site