lkml.org 
[lkml]   [2009]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] vga: implements VGA arbitration on Linux
On Tue 2009-07-14 15:57:29, Tiago Vignatti wrote:
> Signed-off-by: Tiago Vignatti <tiago.vignatti@nokia.com>



> ---

Some patch description might be useful.

> @@ -0,0 +1,1120 @@
> +/*
> + * vgaarb.c
> + *
> + * (C) Copyright 2005 Benjamin Herrenschmidt <benh@kernel.crashing.org>
> + * (C) Copyright 2007 Paulo R. Zanoni <przanoni@gmail.com>
> + * (C) Copyright 2007, 2009 Tiago Vignatti <vignatti@freedesktop.org>
> + *

If you have copyright, GPL would be cool.

> +struct vga_device {
> + struct list_head list;
> + struct pci_dev *pdev;
> + unsigned int decodes; /* what does it decodes */
> + unsigned int owns; /* what does it owns */
> + unsigned int locks; /* what does it locks */

spelling in comments? And ...how can int tell me what it owns?


> +
> +static LIST_HEAD(vga_list);
> +static DEFINE_SPINLOCK(vga_lock);
> +static DECLARE_WAIT_QUEUE_HEAD(vga_wait_queue);
> +
> +#ifndef __ARCH_HAS_VGA_DEFAULT_DEVICE
> +static struct pci_dev *vga_default;
> +#endif
> +
> +static void vga_arb_device_card_gone(struct pci_dev *pdev);
> +
> +/* Find somebody in our list */
> +static struct vga_device *vgadev_find(struct pci_dev *pdev)
> +{
> + struct vga_device *vgadev;
> +
> + list_for_each_entry(vgadev, &vga_list, list)
> + if (pdev == vgadev->pdev)
> + return vgadev;
> + return NULL;
> +}

Indent using tabs. checkpatch?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-07-18 13:49    [W:0.056 / U:1.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site