Messages in this thread | | | Date | Sat, 18 Jul 2009 13:29:28 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip] tracing: use defined fields to print formats |
| |
* Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> It seems that ftrace_format_##call() and > ftrace_define_fields_##call() are duplicate more or less. > > trace_define_field() defines fields and links them into strcut > ftrace_event_call. We reuse them to print formats and remove > ftrace_format_##call(). It make all things simpler. > > TRACE_EVENT_FORMAT_NOFILTER is dropped. Because we should > "trace_define_field()" fields for all struct ftrace_event_call, > even it's no filter. > > Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com> > --- > diff --git a/include/linux/ftrace_event.h b/include/linux/ftrace_event.h > index 5c093ff..738b33d 100644
Minor request for future patches: could you please include the diffstat all the time? Makes it much easier to see the general impact of a patch.
Ingo
| |