Messages in this thread Patch in this message | | | Date | Sat, 18 Jul 2009 12:20:31 +0200 | From | Pavel Machek <> | Subject | iwl3945: fix LED config option |
| |
On Thu 2009-07-09 08:39:46, reinette chatre wrote: > On Thu, 2009-07-09 at 02:38 -0700, Pavel Machek wrote: > > > > > > > > (Also wifi LED stopped working on x60, but that's older issue). > > > > > > Is there a bug report for this? > > > > Well... I thought that was known issue? > > > > Anyway, wifi LED used to work on x60 before driver rewrite. Now it is > > broken. I thought it is known/missing functionality? ...but I'd like > > to get it back :-). > > Sorry ... but I have to ask ... did you compile with > CONFIG_IWLWIFI_LEDS ? If you still have issues - please do submit a bug > report.
Aha, this explains it:
Enable LED support in iwlagn and iwl3945 drivers (IWLWIFI_LEDS) [N/y] (NEW) ?
Sorry, no help available for this option yet.
...maybe LEDS should be default Y? Pavel
---
IWLWIFI_LEDS option should certainly have help comment, and should default to y. Actually I wonder if it should be user configurable at all, is there good reason?
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig index e092af0..95d9aa5 100644 --- a/drivers/net/wireless/iwlwifi/Kconfig +++ b/drivers/net/wireless/iwlwifi/Kconfig @@ -9,6 +9,10 @@ config IWLWIFI config IWLWIFI_LEDS bool "Enable LED support in iwlagn and iwl3945 drivers" depends on IWLWIFI + default y + ---help--- + Useful to get Wifi LED working at least on Thinkpad notebooks. + config IWLWIFI_SPECTRUM_MEASUREMENT bool "Enable Spectrum Measurement in iwlagn driver"
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |