lkml.org 
[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] tracing/events: add missing type info of dynamic arrays
On Thu, Jul 16, 2009 at 10:53:34AM +0800, Li Zefan wrote:
> From: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> The format file doesn't contain enough information for
> __dynamic_array/__string. The type name is missing.
>
> Before:
> # cat format:
> name: irq_handler_entry
> ...
> field:__data_loc name; offset:16; size:2;
>
> After:
> # cat format:
> name: irq_handler_entry
> ...
> field:__data_loc char[] name; offset:16; size:2;
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>


Looks good to me, but I'd prefer to wait for Steve Ack, since he wasn't
sure...

Thanks.


> ---
> include/trace/ftrace.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/ftrace.h b/include/trace/ftrace.h
> index 1867553..cc78943 100644
> --- a/include/trace/ftrace.h
> +++ b/include/trace/ftrace.h
> @@ -120,7 +120,7 @@
>
> #undef __dynamic_array
> #define __dynamic_array(type, item, len) \
> - ret = trace_seq_printf(s, "\tfield:__data_loc " #item ";\t" \
> + ret = trace_seq_printf(s, "\tfield:__data_loc " #type "[] " #item ";\t"\
> "offset:%u;\tsize:%u;\n", \
> (unsigned int)offsetof(typeof(field), \
> __data_loc_##item), \
> @@ -279,7 +279,7 @@ ftrace_raw_output_##call(struct trace_iterator *iter, int flags) \
>
> #undef __dynamic_array
> #define __dynamic_array(type, item, len) \
> - ret = trace_define_field(event_call, "__data_loc" "[" #type "]", #item,\
> + ret = trace_define_field(event_call, "__data_loc " #type "[]", #item, \
> offsetof(typeof(field), __data_loc_##item), \
> sizeof(field.__data_loc_##item), 0);
>
> -- 1.6.3



\
 
 \ /
  Last update: 2009-07-17 06:47    [W:0.044 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site