lkml.org 
[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] block: sysfs fix mismatched queue_var_{store,show} in 64bit kernel
Hello,

Danny Feng wrote:
> Thank you very much for the review, I've attached v3 patch follow
> your advices, please help me review.

Thanks. I queued the patch on the following temp block tree.

git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git tj-block-for-linus

> Another thing on block sysfs is that we can echo some invalid value
> (e.g 123abc), should sysfs return -EINVAL for those?

sysfs nodes are only accessible from root and it's customary to not
invest too much into safe guarding the input. So, leaving as it is
should be fine, I think.

--
tejun


\
 
 \ /
  Last update: 2009-07-17 09:55    [W:0.026 / U:5.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site