Messages in this thread |  | | Date | Fri, 17 Jul 2009 15:31:33 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 1/4] drivers/block: adjust NULL test |
| |
Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > dtp is derefenced on the lines above the test !dtp, and so it cannot be > NULL at this point. > > A simplified version of the semantic match that finds this problem is as > follows: (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @r@ > expression x,E,E1; > identifier f,l; > position p1,p2; > @@ > > *x@p1->f = E1; > ... when != x = E > when != goto l; > ( > *x@p2 == NULL > | > *x@p2 != NULL > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk>
Indeed, added to my temp block tree. Will forward upstream in a few days.
Thanks.
-- tejun
|  |