[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[patch 16/24] md: fix error path when duplicate name is found on md device creation.
2.6.30-stable review patch.  If anyone has any objections, please let us know.


From: NeilBrown <>

commit 1ec22eb2b4a2e1a763106bce36b11c02eaa84e61 upstream.

When an md device is created by name (rather than number) we need to
check that the name is not already in use. If this check finds a
duplicate, we return an error without dropping the lock or freeing
the newly create mddev.
This patch fixes that.

Found-by: Jiri Slaby <>
Signed-off-by: NeilBrown <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/md/md.c | 2 ++
1 file changed, 2 insertions(+)

--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -3876,6 +3876,8 @@ static int md_alloc(dev_t dev, char *nam
if (mddev2->gendisk &&
strcmp(mddev2->gendisk->disk_name, name) == 0) {
+ mutex_unlock(&disks_mutex);
+ mddev_put(mddev);
return -EEXIST;

 \ /
  Last update: 2009-07-17 22:33    [W:0.093 / U:36.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site