lkml.org 
[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/20] ceph: debugging
On Fri, 17 Jul 2009, Andi Kleen wrote:
> Good.
>
> Sorry for not doing more (and more serious) reviews, not enough
> time right now.

You've been helpful nonetheless, thanks! :)

> > #define _dout(fmt, args...) \
> > pr_debug(" %12.12s:%-4d : " fmt "%s", \
> > ceph_file_part(__FILE__, sizeof(__FILE__)), \
> > __LINE__, args);
>
> That seems like a wasteful way to do this -- i bet you could
> shrink binary size with debugging on considerably if you move
> the file_part into a function.

If you mean ceph_file_part shouldn't be inline, definitely. Beyond that
I'm not sure what more to change... it's just a few extra chars on the
format string and 2 calls instead of 1?

sage


\
 
 \ /
  Last update: 2009-07-17 21:55    [W:0.084 / U:7.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site