lkml.org 
[lkml]   [2009]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 18/20] ceph: debugging
Good.

Sorry for not doing more (and more serious) reviews, not enough
time right now.

> #define _dout(fmt, args...) \
> pr_debug(" %12.12s:%-4d : " fmt "%s", \
> ceph_file_part(__FILE__, sizeof(__FILE__)), \
> __LINE__, args);

That seems like a wasteful way to do this -- i bet you could
shrink binary size with debugging on considerably if you move
the file_part into a function.

-Andi


--
ak@linux.intel.com -- Speaking for myself only.


\
 
 \ /
  Last update: 2009-07-17 20:59    [W:0.052 / U:51.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site