Messages in this thread Patch in this message |  | | Date | Fri, 17 Jul 2009 16:19:26 +0200 | From | Roel Kluin <> | Subject | Re: [PATCH] ia32: strncpy does not null terminate string |
| |
strlcpy() will always null terminate the string.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- > The proof is flawed: Global variables are automatically '\0' > initialized.
Hmm, I see, how about using strlcpy instead?
diff --git a/arch/x86/ia32/sys_ia32.c b/arch/x86/ia32/sys_ia32.c index 085a8c3..528972f 100644 --- a/arch/x86/ia32/sys_ia32.c +++ b/arch/x86/ia32/sys_ia32.c @@ -687,7 +687,7 @@ long sys32_vm86_warning(void) compat_printk(KERN_INFO "%s: vm86 mode not supported on 64 bit kernel\n", me->comm); - strncpy(lastcomm, me->comm, sizeof(lastcomm)); + strlcpy(lastcomm, me->comm, sizeof(lastcomm)); } return -ENOSYS; }
|  |