lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH #tj-block-for-linus] block: fix failfast merge testing in elv_rq_merge_ok()
On 07/16/2009 11:35 AM, Tejun Heo wrote:
> Boaz Harrosh wrote:
>> OK So could you put a FIXME: and fat comment, on that weird "!"(s)
>> everywhere?
>
> Yeap, sure. How about something like the following?
>
> /*
> * Don't merge if failfast settings don't match. The negation

- * Don't merge if failfast settings don't match. The negation
+ * Don't merge if failfast settings don't match.
+ * FIXME: The negation ...

> * in front of each condition is necessary because bio and
> * request flags use different bit positions and the accessors
> * return those bits directly. This ugliness will soon go
> * away.
> */
>

Boaz


\
 
 \ /
  Last update: 2009-07-16 10:51    [from the cache]
©2003-2011 Jasper Spaans