Messages in this thread | | | Date | Thu, 16 Jul 2009 13:10:23 +0900 | Subject | Re: [PATCH 2/3] mm: shrink_inactive_lis() nr_scan accounting fix fix | From | Minchan Kim <> |
| |
Good. I decided making patch like this since I knew this problem. You are too diligent :)
Thanks for good attitude.
On Thu, Jul 16, 2009 at 9:53 AM, KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com> wrote: > Subject: [PATCH] mm: shrink_inactive_lis() nr_scan accounting fix fix > > If sc->isolate_pages() return 0, we don't need to call shrink_page_list(). > In past days, shrink_inactive_list() handled it properly. > > But commit fb8d14e1 (three years ago commit!) breaked it. current shrink_inactive_list() > always call shrink_page_list() although isolate_pages() return 0. > > This patch restore proper return value check. > > > Requirements: > o "nr_taken == 0" condition should stay before calling shrink_page_list(). > o "nr_taken == 0" condition should stay after nr_scan related statistics > modification. > > > Cc: Wu Fengguang <fengguang.wu@intel.com> > Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Reviewed-by: Minchan Kim <minchan.kim@gmail.com>
-- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |