Messages in this thread | | | Date | Thu, 16 Jul 2009 17:35:11 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH #tj-block-for-linus] block: fix failfast merge testing in elv_rq_merge_ok() |
| |
Boaz Harrosh wrote: > OK So could you put a FIXME: and fat comment, on that weird "!"(s) > everywhere?
Yeap, sure. How about something like the following?
/* * Don't merge if failfast settings don't match. The negation * in front of each condition is necessary because bio and * request flags use different bit positions and the accessors * return those bits directly. This ugliness will soon go * away. */
-- tejun
| |