lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH #tj-block-for-linus] block: fix failfast merge testing in elv_rq_merge_ok()
Boaz Harrosh wrote:
> OK So could you put a FIXME: and fat comment, on that weird "!"(s)
> everywhere?

Yeap, sure. How about something like the following?

/*
* Don't merge if failfast settings don't match. The negation
* in front of each condition is necessary because bio and
* request flags use different bit positions and the accessors
* return those bits directly. This ugliness will soon go
* away.
*/

--
tejun


\
 
 \ /
  Last update: 2009-07-16 10:39    [W:0.061 / U:5.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site