lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction'
>-----Original Message-----
>From: Rafael J. Wysocki [mailto:rjw@sisk.pl]
>Sent: Friday, July 17, 2009 9:52 AM
>To: Lu, Guanqun
>Cc: linux-kernel@vger.kernel.org; mingo@elte.hu; jeremy@goop.org
>Subject: Re: [PATCH 1/3] add flag IRQF_NO_SUSPEND in 'struct irqaction'
>
>On Friday 17 July 2009, Guanqun Lu wrote:
>> We currently only bypass IRQF_TIMER in '__disable_irq',
>> but Xen specific IRQs should not be disabled either.
>> This commit adds a new flag to accompolish this goal
>> without being mixed up with IRQF_TIMER flag.
>
>For some obscure reasons [2/3] didn't reach my inbox. The other 2 patches
>look fine to me.

I'm sending patch [2/3] via attachment in case it's lost accidentally by git-send-email again.
Sorry for the inconvenience it may cause.

Guanqun

>
>Best,
>Rafael
>
>
>> Signed-off-by: Guanqun Lu <guanqun.lu@intel.com>
>> ---
>> include/linux/interrupt.h | 1 +
>> kernel/irq/manage.c | 3 ++-
>> 2 files changed, 3 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
>> index 2721f07..99264c3 100644
>> --- a/include/linux/interrupt.h
>> +++ b/include/linux/interrupt.h
>> @@ -58,6 +58,7 @@
>> #define IRQF_PERCPU 0x00000400
>> #define IRQF_NOBALANCING 0x00000800
>> #define IRQF_IRQPOLL 0x00001000
>> +#define IRQF_NO_SUSPEND 0x00002000
>>
>> /*
>> * Bits used by threaded handlers:
>> diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
>> index 50da676..3dc4e74 100644
>> --- a/kernel/irq/manage.c
>> +++ b/kernel/irq/manage.c
>> @@ -192,7 +192,8 @@ static inline int setup_affinity(unsigned int irq, struct irq_desc
>*desc)
>> void __disable_irq(struct irq_desc *desc, unsigned int irq, bool suspend)
>> {
>> if (suspend) {
>> - if (!desc->action || (desc->action->flags & IRQF_TIMER))
>> + if (!desc->action ||
>> + (desc->action->flags & (IRQF_TIMER | IRQF_NO_SUSPEND)))
>> return;
>> desc->status |= IRQ_SUSPENDED;
>> }
[unhandled content-type:application/octet-stream]
\
 
 \ /
  Last update: 2009-07-17 04:21    [W:0.062 / U:2.956 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site