lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: HTC Dream: qdsp support for staging
On Thu 2009-07-16 16:00:42, Greg KH wrote:
> On Fri, Jul 10, 2009 at 10:37:10AM +0200, Pavel Machek wrote:
> > From: Iliyan Malchev <ibm@android.com>
> >
> > QDSP code is neccessarry for communication with some hardware
> > components on HTC Dream, including camera hardware. It also drives DSP
> > coproccessor.
> >
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> Please don't compress patches :(

I had to -- in order to fit to lkml maillist limits.

> Your patch didn't have any way to actually build the code, care to
> respin it and add the proper Kconfig and Makefile hooks?

Well, resending 100K+ patch to get 3 missing lines is somewhat
"interesting"... and the problem is that proper Kconfig/Makefile hooks
actually depend on order in which you apply the patches.

Would it be possible to just apply the 3 patches, with me supplying
Kconfig/Makefile hooks in patch #4? That's sometimes used to
aid bisectability, and it would save me quite a lot of work (and
possible mistakes) that way.

[I'd hate to set up quilt just to get 3 lines in Makefile into the
right series of 3 patches, and if I do it by hand there's chance of
mistakes...]

Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2009-07-17 03:05    [W:0.068 / U:7.352 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site