lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: count only reclaimable lru pages
On Thu, 16 Jul 2009 06:34:55 -0700
"Wu, Fengguang" <fengguang.wu@intel.com> wrote:

> global_lru_pages() / zone_lru_pages() can be used in two ways:
> - to estimate max reclaimable pages in determine_dirtyable_memory()
> - to calculate the slab scan ratio
>
> When swap is full or not present, the anon lru lists are not
> reclaimable and thus won't be scanned. So the anon pages shall not be
> counted. Also rename the function names to reflect the new meaning.
>
> It can greatly (and correctly) increase the slab scan rate under high
> memory pressure (when most file pages have been reclaimed and swap is
> full/absent), thus avoid possible false OOM kills.
>
> Cc: Minchan Kim <minchan.kim@gmail.com>
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> include/linux/vmstat.h | 11 +--------
> mm/page-writeback.c | 5 ++--
> mm/vmscan.c | 44 +++++++++++++++++++++++++++++----------
> 3 files changed, 38 insertions(+), 22 deletions(-)
>

Looks nice to me, including the naming. FWIW (given that it's been
years since I did any serious VM work):

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

--
Jesse Barnes, Intel Open Source Technology Center


\
 
 \ /
  Last update: 2009-07-16 18:25    [W:0.050 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site