lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: count only reclaimable lru pages
On Thu, Jul 16, 2009 at 10:00:51PM +0800, Christoph Lameter wrote:
> On Thu, 16 Jul 2009, Wu Fengguang wrote:
>
> > When swap is full or not present, the anon lru lists are not reclaimable
> > and thus won't be scanned. So the anon pages shall not be counted. Also
> > rename the function names to reflect the new meaning.
> >
> > It can greatly (and correctly) increase the slab scan rate under high memory
> > pressure (when most file pages have been reclaimed and swap is full/absent),
> > thus avoid possible false OOM kills.
>
> Reclaimable? Are all pages on the LRUs truly reclaimable?

No, only possibly reclaimable :)

What would you suggest? In fact I'm not totally comfortable with it.
Maybe it would be safer to simply stick with the old _lru_pages naming?

Thanks,
Fengguang

> Aside from that nit.
>
> Reviewed-by: Christoph Lameter <cl@linux-foundation.org>


\
 
 \ /
  Last update: 2009-07-16 16:27    [W:0.075 / U:1.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site