lkml.org 
[lkml]   [2009]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 02/06] Fix compilation warning for fs/ubifs/commit.c
Stefan Richter wrote:
> So, is uninitialized_var() a good fix here? I'd say it's not a
> particular good one. Count the lines of code of dbg_check_old_index()
> and the maximum indentation level of it. Then remember the teachings of
> CodingStyle. :-) See? dbg_check_old_index() clearly isn't a prime
> example of best kernel coding practice. /Perhaps/ a little bit of
> refactoring would make it easier to read, and as a bonus side effect,
> make it unnecessary to use the slightly dangerous and
> uninitialized_var() macro here.

PS:
On the other hand, it is debug code. Is it bound to stay in there
forever? If not, then it's surely not worth the developer time to
beautify it.
--
Stefan Richter
-=====-==--= -=== =----
http://arcgraph.de/sr/


\
 
 \ /
  Last update: 2009-07-16 14:01    [W:0.071 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site