Messages in this thread | | | Date | Wed, 15 Jul 2009 11:10:31 +0200 | From | Takashi Iwai <> | Subject | Re: sound/pci/riptide/riptide.c compiler warning |
| |
At Wed, 15 Jul 2009 11:57:30 +0530, Jaswinder Singh Rajput wrote: > > I am getting this compiler warning in linus tree : > > CC [M] sound/pci/riptide/riptide.o > sound/pci/riptide/riptide.c: In function ‘alsa_card_riptide_init’: > sound/pci/riptide/riptide.c:2200: warning: ignoring return value of ‘__pci_register_driver’, declared with attribute warn_unused_result > > This fixes the warning in my case, hope this will be helpful : > > diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c > index 235a71e..fd8a552 100644 > --- a/sound/pci/riptide/riptide.c > +++ b/sound/pci/riptide/riptide.c > @@ -2197,9 +2197,9 @@ static int __init alsa_card_riptide_init(void) > if (err < 0) > return err; > #if defined(SUPPORT_JOYSTICK) > - pci_register_driver(&joystick_driver); > + err = pci_register_driver(&joystick_driver); > #endif > - return 0; > + return err;
In that case, the formerly registered audio driver should be unregistered before returning the error from the probe callback. Could you fix that?
thanks,
Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |