lkml.org 
[lkml]   [2009]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: sound/pci/riptide/riptide.c compiler warning
At Wed, 15 Jul 2009 11:57:30 +0530,
Jaswinder Singh Rajput wrote:
>
> I am getting this compiler warning in linus tree :
>
> CC [M] sound/pci/riptide/riptide.o
> sound/pci/riptide/riptide.c: In function ‘alsa_card_riptide_init’:
> sound/pci/riptide/riptide.c:2200: warning: ignoring return value of ‘__pci_register_driver’, declared with attribute warn_unused_result
>
> This fixes the warning in my case, hope this will be helpful :
>
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index 235a71e..fd8a552 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -2197,9 +2197,9 @@ static int __init alsa_card_riptide_init(void)
> if (err < 0)
> return err;
> #if defined(SUPPORT_JOYSTICK)
> - pci_register_driver(&joystick_driver);
> + err = pci_register_driver(&joystick_driver);
> #endif
> - return 0;
> + return err;

In that case, the formerly registered audio driver should be
unregistered before returning the error from the probe callback.
Could you fix that?


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-07-15 11:13    [W:1.183 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site