[lkml]   [2009]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 1/2] vga: implements VGA arbitration on Linux
On Wed, Jul 15, 2009 at 2:15 AM, Greg KH<> wrote:
> Minor comment:
>> +#ifdef DEBUG
>> +     printk(KERN_DEBUG "%s\n", __func__);
>> +#endif
> You should just use 'dev_dbg() for any debugging statments like this.
> You can turn them on and off dynamically, and you get all of the proper
> device information as to what is going on automatically.
> Plus, there's no need for a #ifdef in the code, which is generally
> frowned apon in .c files.

We don't have a device in this case, vga arb is more of an abstraction than
an actual device.

I suppose if we were feeling crazy we could add a platform device for it.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2009-07-16 05:57    [W:0.150 / U:5.888 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site