[lkml]   [2009]   [Jul]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] mm: Warn once when a page is freed with PG_mlocked set V2
    On Wed, 15 Jul 2009, Mel Gorman wrote:

    > -static inline int free_pages_check(struct page *page)
    > +static inline int free_pages_check(struct page *page, int wasMlocked)
    > {
    > + WARN_ONCE(wasMlocked, KERN_WARNING
    > + "Page flag mlocked set for process %s at pfn:%05lx\n"
    > + "page:%p flags:0x%lX\n",
    > + current->comm, page_to_pfn(page),
    > + page, page->flags|__PG_MLOCKED);
    > +
    > if (unlikely(page_mapcount(page) |

    There is already a free_page_mlocked() that is only called if the mlock
    bit is set. Move it into there to avoid having to run two checks in the
    hot codee path?

    Also __free_pages_ok() now has a TestClearMlocked in the hot code path.
    Would it be possible to get rid of the unconditional use of an atomic
    operation? Just check the bit and clear it later in free_page_mlocked()?

     \ /
      Last update: 2009-07-15 16:35    [W:0.022 / U:65.232 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site