Messages in this thread |  | | Date | Tue, 14 Jul 2009 09:15:14 -0700 | From | Greg KH <> | Subject | Re: [PATCH 1/2] vga: implements VGA arbitration on Linux |
| |
Minor comment:
> +#ifdef DEBUG > + printk(KERN_DEBUG "%s\n", __func__); > +#endif
You should just use 'dev_dbg() for any debugging statments like this. You can turn them on and off dynamically, and you get all of the proper device information as to what is going on automatically.
Plus, there's no need for a #ifdef in the code, which is generally frowned apon in .c files.
thanks,
greg k-h
|  |