Messages in this thread | | | Date | Mon, 13 Jul 2009 13:28:21 +0800 | From | Li Zefan <> | Subject | Re: [PATCH] hw_breakpoint: remove sample code from hw_breakpoint.h |
| |
(sorry for the late reply, I didn't see this mail..)
Frederic Weisbecker wrote: > On Tue, Jul 07, 2009 at 01:40:11PM +0800, Li Zefan wrote: >> The sample code is a bit out-dated, and there's already a >> sample in sample/hw_breakpoint/. > > > IMHO these bits of comments are useful and don't overlap the role > of the samples in sample/ > They only stand there as a quick summup. > > No? >
The sample here sets a breakpoint on pid_max, which is what the sample in sample/ does.
And the code here is out-dated (and incomplete). We can fix it, but whenver someone changes the APIs, he may forget to update the comments. We know comments never catch up with code.
So I inclined to delete it, and add a link to sample/.
| |