lkml.org 
[lkml]   [2009]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND PATCH 0/11] kernel:lockdep:replace DFS with BFS

* Ming Lei <tom.leiming@gmail.com> wrote:

> > I don't have a strong opinion on this. I just don't think the
> > shortest path is the most important if there are many many
> > paths. Whatever AB-BA is encountered, all of them must be fixed.
> > What might give a degree of importance for such bad circle is
> > the window in which it triggers.
>
> The shortest path is just a characteristic of BFS, and we do not
> need to pay extra work for it. So finding the shortest circle
> have not any bad effect at least.
>
> IMHO, troubleshooting from the shortest circle is easier than from
> other circle.

Agreed. Making lockdep reports more readable (i.e. smaller) is a
very important goal.

Often the longer circles are just a side-effect of the shorter
circles and fixing the short one will fix the large ones too. So
printing the smallest is an advantage IMO.

Ingo


\
 
 \ /
  Last update: 2009-07-13 09:05    [W:0.101 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site