Messages in this thread | | | Date | Mon, 13 Jul 2009 09:02:48 +0200 | From | Ingo Molnar <> | Subject | Re: [RESEND PATCH 0/11] kernel:lockdep:replace DFS with BFS |
| |
* Ming Lei <tom.leiming@gmail.com> wrote:
> > I don't have a strong opinion on this. I just don't think the > > shortest path is the most important if there are many many > > paths. Whatever AB-BA is encountered, all of them must be fixed. > > What might give a degree of importance for such bad circle is > > the window in which it triggers. > > The shortest path is just a characteristic of BFS, and we do not > need to pay extra work for it. So finding the shortest circle > have not any bad effect at least. > > IMHO, troubleshooting from the shortest circle is easier than from > other circle.
Agreed. Making lockdep reports more readable (i.e. smaller) is a very important goal.
Often the longer circles are just a side-effect of the shorter circles and fixing the short one will fix the large ones too. So printing the smallest is an advantage IMO.
Ingo
| |