Messages in this thread | | | Date | Tue, 14 Jul 2009 00:22:51 +0430 | From | Ali Gholami Rudi <> | Subject | Re: [PATCH 0/2] fbdev: add fillrect and copyarea ioctls |
| |
Arnd Bergmann <arnd@arndb.de> wrote: > On Monday 13 July 2009, Greg KH wrote: > > On Mon, Jul 13, 2009 at 07:47:09PM +0430, Ali Gholami Rudi wrote: > > > Is there any reason for not adding these ioctls to fbdev? I searched > > > the net and couldn't any. Anyway, these patches simply implement those > > > ioctls. > > > > Have you also added the needed 32 vs. 64 bit handlers for these ioctls? > > > > They are not there, but could be trivially added with > > diff --git a/drivers/video/fbmem.c b/drivers/video/fbmem.c > index f8a09bf..ce107c4 100644 > --- a/drivers/video/fbmem.c > +++ b/drivers/video/fbmem.c > @@ -1285,6 +1285,8 @@ static long fb_compat_ioctl(struct file *file, unsigned int cmd, > case FBIOPAN_DISPLAY: > case FBIOGET_CON2FBMAP: > case FBIOPUT_CON2FBMAP: > + case FBIOCOPYAREA: > + case FBIOFILLRECT: > arg = (unsigned long) compat_ptr(arg); > case FBIOBLANK: > ret = do_fb_ioctl(info, cmd, arg);
Thanks, I'll update the patches.
Ali
| |